Inefficient Admin Tree cache building [5.3.0-B1]

The Admin Tree is main navigation tool in the Admin Console. Each unit can add it's own sections to the Admin Tree. To ensure top speed of Admin Console the Admin Tree cache is used.

I've found following issues with it:

1. The "$this->Application->UnitConfigReader->ReReadConfigs" is being called even, when full unit config cache rebuild is happening resulting in processing time increase for no reason
2. the dedicated "getUnitConfigsWithoutPriority" and "getUnitConfigsWithPriority" methods of kUnitConfigReader class are not being used and therefore priority sorting code is duplicated

Solution

1. make ReReadConfigs method do nothing, when full unit config cache rebuild is in progress
2. use "getUnitConfigsWithoutPriority" and "getUnitConfigsWithPriority" methods

Related Discussions

• Doing complete cache reset calls OnAfterConfigRead twice
• Incorrect SQL queries with duplicate JOIN clauses

Related Tasks

INP-1426 - Getting issue details... STATUS