/
[emails] Email event usage refactoring [5.2.0-B3]

[emails] Email event usage refactoring [5.2.0-B3]

Owned by Alex
Last updated: Dec 22, 2024

Imported From: http://groups.google.com/group/in-portal-dev/browse_thread/thread/230726ffbb324dae#

Currently e-mail event sending process (internally) doesn't represent real world model, which makes it hard to improve this code with new features.

I'm proposing to:

  1. create kEmail class with following public methods:
    1. findEvent($name, $type)
    2. setParams($params)
    3. send()
  2. make $this->sender refer to kEmailSendingHelper class instance for easy access across all methods
  3. move existing code from EmailEventsEventHandler into new kEmail class
  4. replace OnEmailEvent event sending with new kEmail class usage

At the end interface of kApplication::EmailEventUser and kApplication::EmailEventAdmin will be almost the same (will return true/false instead of kEvent object), so no need to change code to make it working again.

Usually nobody relies on e-mail sent fact in their code anyway.

Related Tasks

INP-999 - Getting issue details... STATUS

INP-1073 - Getting issue details... STATUS