Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 4 Next »

Imported From: http://groups.google.com/group/in-portal-dev/browse_thread/thread/230726ffbb324dae#

Currently e-mail event sending process (internally) doesn't represent real world model, which makes it hard to improve this code with new features.

I'm proposing to:

  1. create kEmail class with following public methods:
    1. findEvent($name, $type)
    2. setParams($params)
    3. send()
  2. make $this->sender refer to kEmailSendingHelper class instance for easy access across all methods
  3. move existing code from EmailEventsEventHandler into new kEmail class
  4. replace OnEmailEvent event sending with new kEmail class usage

At the end interface of kApplication::EmailEventUser and kApplication::EmailEventAdmin will be almost the same (will return true/false instead of kEvent object), so no need to change code to make it working again.

Usually nobody relies on e-mail sent fact in their code anyway.

Related Tasks

Error rendering macro 'jira' : Unable to locate Jira server for this macro. It may be due to Application Link configuration.

Unable to locate Jira server for this macro. It may be due to Application Link configuration.

  • No labels