Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

Imported From: http://groups.google.com/group/in-portal-dev/browse_thread/thread/230726ffbb324dae#

Currently e-mail event sending process (internally) doesn't represent real
world model, which makes it hard to improve this code with new features.

I'm proposing to:   1.

  1. create kEmail class with following public methods:

      ...

        1. findEvent($name, $type)

      ...

        1. setParams($params)

      ...

        1. send()

      ...

      1. make $this->sender refer to kEmailSendingHelper class instance for

      ...

      1. easy access across all methods

      ...

      1. move existing code from EmailEventsEventHandler into new kEmail class

      ...

      1. replace OnEmailEvent event sending with new kEmail class usage

      At the end interface of kApplication::EmailEventUser and
      and kApplication::EmailEventAdmin will be almost the same (will return
      return true/false instead of kEvent object), so no need to change code to make it
      it working again.

      Usually nobody relies on e-mail sent fact in their code anyway.Task:

      Related Tasks

      Jira Legacy
      In-Portal Issue Tracker
      serverSystem Jira
      columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId513b375f-8291-3313-9d9f-704c39b1f915
      keyINP-999

      --
      Best Regards,

      http://www.in-portal.com
      http://www.alex-time.com

      Jira Legacy
      serverSystem Jira
      columnIdsissuekey,summary,issuetype,created,updated,duedate,assignee,reporter,priority,status,resolution
      columnskey,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
      serverId513b375f-8291-3313-9d9f-704c39b1f915
      keyINP-1073