Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method

Components

Labels

Description

Plan:

  1. rename "OrderHelper::getCreditCartType" method into "OrderHelper::getCreditCardType" (+fix all usage places)

  2. add "OrderHelper::getCreditCartType" method (yes, old name) that would (to preserve BC):

    • have the "@depricated" annotation in DocBlock

    • trigger silenced deprecation notice telling that "OrderHelper::getCreditCardType" method should be used instead

    • return result of calling "OrderHelper::getCreditCardType" method

Context Information

None

Additional information (do not use)

None

Activity

Alex November 28, 2016 at 9:26 AM

Closing issues of a released version.

[API] Administrator November 24, 2016 at 8:30 PM

User committed a fix to 5.2.x. Commit Message:

Fixes https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 - Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method

Differential Revision: http://qa.in-portal.org/D216

Alex November 24, 2016 at 8:30 PM

alex closed D216: https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method by committing rMINC16464: Fixes https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 - Rename "OrderHelper::getCreditCartType" into "OrderHelper….
alex updated the diff for D216: https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.

Alex November 19, 2016 at 2:26 PM

alex accepted D216: https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.
D216: https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method is now accepted and ready to land.
alex added inline comments to D216: https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.

Inline Comments
modules/in-commerce/units/helpers/order_helper.php:181 https://github.com/aik099/CodingStandard/commit/c7ef78c8ad44b8d00275b223a94d7781a1eeb808

Alex November 19, 2016 at 2:25 PM

alex updated the summary for D216: https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.
alex updated the test plan for D216: https://in-portal.atlassian.net/browse/MINC-168#icft=MINC-168 Rename "OrderHelper::getCreditCartType" into "OrderHelper::getCreditCardType" method.

Fixed

Details

Priority

Assignee

Reporter

Developer

Reviewer

Change Log Group

Changed

Change Log Message

Patch Instructions

Patches must be submitted through Phabricator.

Story Points

Fix versions

Created March 29, 2016 at 7:34 AM
Updated December 29, 2024 at 11:26 PM
Resolved November 24, 2016 at 8:30 PM