Column selector (picker) doesn't remember multilingual column position

Components

Labels

Description

Column selector (picker) doesn't remember multilingual column position. For example we have "Subject" field, which is multilingual. We place it in grid and later kMultiLanguage formatter replaces it with "l<ID>_Subject", where <ID> is ID of current language. So at the end column picker remembers position of "l1_Subject" column. Then we change language to ID = 2. Our column becomes "l2_Subject", which is new to column picker and "l1_Subject" column is gone. This was same column, but on different language is added at the end of the list, because column picker considers it as newly added column.

Context Information

None

Additional information (do not use)

I suppose we could fix this by using this idea:

1. in case if kMultiLanguage formatter renames grid column, then it added new option "formatter_renamed" to it's declaration
2. when column picker identifies column position, then it should strip language prefix ("l<ID>_") from column name (only for position detection).

Attachments

4

Activity

Alex May 11, 2010 at 7:59 AM

Closing all tasks from released versions.

Alex March 23, 2010 at 9:01 PM

Fix committed to [b]5.0.x branch/b. Commit Message:

Fixes #0000555: Column selector (picker) doesn't remember multilingual column position

Dmitry Andrejev March 23, 2010 at 8:30 PM

Good work Patch works well now!

Alex March 23, 2010 at 7:14 PM

I've actually forgot to add one more file to original patch. Here is new patch "ml_grid_column_fix2_v2.patch".

Alex March 23, 2010 at 8:29 AM

This patch is missing once change:

$grids[$name]['Fields'][$field_name]['formatter_renamed'] = true;

from kMultiLanguage class. I'll check if I missed it in this patch or it's just in another task, that should be applied before this one.

Fixed

Details

Priority

Assignee

Reporter

Developer

Patch Instructions

Patches must be submitted through Phabricator.

External issue ID

External issue URL

Fix versions

Affects versions

Created January 26, 2010 at 7:08 PM
Updated December 29, 2024 at 9:22 PM
Resolved May 11, 2010 at 7:59 AM