Properly handle constant absence during category cache rebuild

Components

Labels

None

Description

In the "\kPermCacheUpdater::initData" method replace defined(constant_name) code with defined('constant_name') code.

Context Information

When these keys (see below) are missing from the "/system/config.php" file, then performing a section cache rebuild would trigger 2 notices (see below):

Settings in "/system/config.php":

$_CONFIG['Database']['DBCollation']
$_CONFIG['Database']['DBCharset']

Notices:

Use of undefined constant SQL_COLLATION - assumed 'SQL_COLLATION'
Use of undefined constant SQL_CHARSET - assumed 'SQL_CHARSET'

Additional information (do not use)

None

Activity

[API] Administrator October 28, 2024 at 11:26 AM

User (SVN User: "alex") committed a fix to 5.2.x. Commit Message:

Fixes - Properly handle constant absence during category cache rebuild

Differential Revision: https://qa.in-portal.org/D480

Fixed

Details
Priority
Minor
Assignee
Alex
Reporter
Alex
Developer
Alex
Reviewer
Erik S.
Change Log Group
Fixed
Change Log Message
Corrected 2 PHP notices, that were happening due to the incorrect database connection configuration during category cache rebuild.
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
Time tracking
31m logged
Story Points
1
Fix versions
5.2.2-B3

Created August 5, 2024 at 6:23 AM

Updated December 29, 2024 at 8:47 PM

Resolved October 28, 2024 at 11:26 AM