Fixed
Details
Priority
MinorAssignee
AlexAlexReporter
AlexAlexDeveloper
AlexAlexChange Log Message
Fixes parallel cache rebuild problem againPatch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
External issue ID
1231External issue URL
Story Points
2Fix versions
Affects versions
Details
Details
Priority
Assignee
Alex
AlexReporter
Alex
AlexDeveloper
Alex
AlexChange Log Message
Fixes parallel cache rebuild problem again
Patch Instructions
Patches must be submitted through Phabricator.
To submit patch via Command Line use Patches Workflow (via Arcanist) tutorial.
To submit patch via Web Interface use Patches Workflow (via Web Interface) tutorial.
External issue ID
1231
External issue URL
Story Points
2
Fix versions
Affects versions
Created March 24, 2012 at 8:38 PM
Updated December 29, 2024 at 9:06 PM
Resolved July 25, 2012 at 10:31 AM
We've implemented parallel cache rebuild protection in 5.2.0-B1 by setting lock before creating new cache. This ensured that all other requests were receiving old cache version or just waiting for a lock to be released.
However I've found a bug in that system too, when multiple visitors, who encountered a missing/outdated cache would set lock in parallel and start rebuild process. This of course would be slightly smaller number of parallel rebuild requests then without protection added in 5.2.0-B1, but still needs to be fixed.