Incorrectly named labels used in System Settings [5.2.1-B1]

Incorrectly named labels used in System Settings [5.2.1-B1]

In

 task we've added a page to ease up new setting adding. We've also introduced some basic format validations there, for example:

  • system setting label must start with "la_config_"

  • system setting heading label must start with "la_section_"

However it seems, that most part of existing system settings doesn't obey these rules, which results in inability to add/edit system setting configuration (not values). Here are statistics:

Heading Label

Setting Count

no label

11

la_config_DefaultIncreaseImportance

5

la_config_DefaultPop

5

la_config_DefaultRating

5

la_config_SearchRel_DefaultKeyword

5

la_config_ShowMultiple

4

la_posts_subheading

1

la_Text_Affiliates

3

la_Text_Articles

17

la_Text_ContactsGeneral

7

la_Text_Coupons

1

la_Text_Currencies

1

la_Text_Date_Time_Settings

2

la_Text_Links

21

la_Text_Manufacturers

2

la_Text_MetaInfo

2

la_Text_Orders

11

la_Text_Polls

2

Total

105

This is 105 incorrect of 386 total, which is 27% of all system settings have incorrect labels.

Looking at Prompt field, that contains a label for system setting name itself numbers are higher: 238 out of 386 doesn't start with "la_config_", which is 61%.

 

I think we need to take care of that as sooner as possible, because adding this extra validation for system settings, while not fixing existing system settings we've shot self in a leg