Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

No Format
Declaration of Intechnic\InPortal\Core\kernel\Console\Command\CompletionCommand::setApplication()
should be compatible with Symfony\Component\Console\Command\Command::setApplication(Symfony\Component\Console\Application $application = NULL)   

Solution

We need to change $application parameter typehint of "setApplication" method to "Application" and inside assert that given object is instance of "ConsoleApplication" class. This way end developer will get an exception either way about parameter type mismatch and we'll ensure that right application object is being used.

Related Tasks